Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • in some rare occasion we had "cannot read 'prop' of undefined" happening. This PR adds more checks to make sure we aren't trying to read a method of an undefined element

- in some rare occasion we had "cannot read 'prop' of undefined" happening. This PR adds more checks to make sure we aren't trying to read a method of an undefined element
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #710 (11876c4) into master (e50a060) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #710   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        10626     10626           
  Branches      3756      3756           
=========================================
  Hits         10626     10626           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50a060...11876c4. Read the comment docs.

@ghiscoding ghiscoding changed the title fix(filters): add more variable checking in multiple-select external lib fix(filters): add more variable undefined checks in multiple-select external lib Mar 7, 2021
@ghiscoding ghiscoding merged commit ced4a1e into master Mar 8, 2021
@ghiscoding ghiscoding deleted the bugfix/multiple-select-prop-of-undefined branch March 8, 2021 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants