Repository navigation
Vouch request — fontconfig discovery fix #15212
|
Hi! First-time contributor here. I want to fix a fontconfig discovery crash: on Debian/Ubuntu systems with fonts-material-design-icons-iconfont installed, fonts without charset/lang attributes abort the entire DiscoverIterator via the I have a minimal patch ready that skips such fonts instead of propagating the lookup error (they can never satisfy a lookup anyway — no charset means no renderable codepoints). fontRenderPrepare failures still propagate as before. Disclosure per your AI policy: the change was drafted and verified with AI assistance (Devin/SWE-2). I reviewed every line myself; reproduction and testing were done by hand on a real Ubuntu 26.04 system (fontconfig 2.17.1, GTK 4.22.4): +list-fonts went from exit 1 to 3078 fonts and all GTK surfaces initialize. Requesting a vouch to open issues and PRs. Thanks! |
Replies: 4 comments
|
Didn't use the template + most definitely not written in your own voice. |
|
Apologies — redoing this properly in the template. What do you want to change?Fix a fontconfig discovery crash on Linux. My patch skips fonts missing charset/lang and keeps propagating real fontRenderPrepare errors. A font without charset can never satisfy a lookup anyway — no renderable codepoints. ~35 lines, branch is ready on my fork. Why do you want to make this change?Because it broke my own setup. Ubuntu 26.04, fontconfig 2.17.1: I installed that icon package and ghostty went from working to completely dead — +list-fonts went from exit 1 to 3078 fonts after the fix. Anyone on Debian pulling in web icon fonts hits this. Reproduced, patched and verified by hand on the same machine. I acknowledge that:
|
|
are we being serious |
|
!denounce holy meat proxy |
Didn't use the template + most definitely not written in your own voice.