Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar width #321

Merged
merged 5 commits into from
May 12, 2023
Merged

Fix bar width #321

merged 5 commits into from
May 12, 2023

Conversation

ghtmtt
Copy link
Owner

@ghtmtt ghtmtt commented May 12, 2023

New option to set the bar width to automatically. Especially useful with time series where the bar width should be manually calculated to milliseconds. With the Auto option enabled, the plotly backend will take care of it

@ghtmtt
Copy link
Owner Author

ghtmtt commented May 12, 2023

fix #319

@ghtmtt
Copy link
Owner Author

ghtmtt commented May 12, 2023

@Gustry do you have any idea of the failure https://github.com/ghtmtt/DataPlotly/actions/runs/4957358610/jobs/8868936585?pr=321#step:5:108? I based the template on your QuickOSM plugin ;)

@Gustry
Copy link
Collaborator

Gustry commented May 12, 2023

Yes, it has been raised on GitHub and mailing list : qgis/QGIS#53053 and qgis/QGIS#53051

The temporary solution is to disable latest from CI or allow failure.

@ghtmtt
Copy link
Owner Author

ghtmtt commented May 12, 2023

thanks @Gustry I missed the mail of the mailing list :)

@ghtmtt ghtmtt merged commit aa4bf76 into master May 12, 2023
@Gustry Gustry deleted the fix_bar_width branch May 12, 2023 12:08
@Gustry
Copy link
Collaborator

Gustry commented May 12, 2023

Sorry, I didn't check the PR when replying.

Any reason why raising to QGIS 3.28 minimum already ?

@ghtmtt
Copy link
Owner Author

ghtmtt commented May 12, 2023

Yes: the custom function to have same plot item colors as the map ones is not compatible with the 3.22. It might be compatible with 3.24 already but since the 3.28 is the current LTR I thought it would be better to have it compatible with version >= LTR

@Gustry
Copy link
Collaborator

Gustry commented May 15, 2023

the custom function to have same plot item colors as the map ones is not compatible with the 3.22.

I could have a look or we could just not add the custom function if QGIS is less than 3.24

There are still a lot of users with QGIS < 3.28.

@ghtmtt
Copy link
Owner Author

ghtmtt commented May 15, 2023

do you have the chance to test the plugin with a 3.24? So we can lower the plugin again to >= 3.24

@Gustry
Copy link
Collaborator

Gustry commented May 15, 2023

Let's keep like this now, a version has been released, and also #323 has been merged ;-)

We can also see it as an argument to make people speeding their migration if they really want.

@ghtmtt
Copy link
Owner Author

ghtmtt commented May 15, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants