Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide link to catalog and catalog item for installed apps #3863

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

kuosandys
Copy link
Contributor

What does this PR do?

This PR adds links to an installed app:

  • on the app name: link to the app's details page for the corresponding AppCatalogEntry
  • on the catalog name: link to the catalog page with the catalog pre-selected

What is the effect of this change to users?

Users are now able to navigate to the installed app's details page by clicking on the app's name:
Screenshot 2022-11-04

Clicking on the installed app's catalog name...
Screenshot 2022-11-04
...should allow them to navigate to the catalog page with the appropriate catalog pre-selected:
Screenshot 2022-11-04

Users who do not have permission to view the catalog item (AppCatalogEntry CR) or the app's catalog will still see these names displayed as plain text. This is to avoid presenting users with links to view resources they do not have sufficient permissions to see.

Any background context you can provide?

Closes giantswarm/roadmap#1389.

@kuosandys kuosandys added the kind/ux-enhancement Improving existing functionality label Nov 4, 2022
@kuosandys kuosandys marked this pull request as ready for review November 4, 2022 11:29
@kuosandys kuosandys requested a review from a team November 4, 2022 11:29
Copy link
Contributor

@gusevda gusevda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kuosandys kuosandys merged commit f75e7c0 into main Nov 8, 2022
@kuosandys kuosandys deleted the add-links-to-installed-app branch November 8, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/ux-enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installed app details should provide link to catalog and catalog item
2 participants