Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer modifies path even when it says it won't #438

Closed
brownp2k opened this issue Sep 25, 2015 · 1 comment
Closed

Installer modifies path even when it says it won't #438

brownp2k opened this issue Sep 25, 2015 · 1 comment

Comments

@brownp2k
Copy link

During the install process, the user is asked to select an option for how to use Git from the command line. The first option is "Use Git from Git Bash only" which claims "...your PATH will not be modified at all."

I had hand-added PATH entries referencing the Git install location (e.g.: C:\Program Files\Git\cmd), and after the install finishes with the first option selected, the hand-added PATH entries were gone.

The first option should do what it says and not modify PATH whatsoever.
@brownp2k brownp2k mentioned this issue Sep 25, 2015
Closed
@brownp2k
Copy link
Author

My apologies, after digging through the source I realized this should have been filed in build-extras.

My suggestion would be to either:

  1. move the PATH-modifying code within the conditional for the other two options, or
  2. update to comment with a warning, or similar, stating that any existing PATH entries for the currently selected installation directory will be removed

My personal preference would be 1, since I dislike when a program tends to muck with my hand-edited PATH entries. I've submitted a pull request for build-extras that does the first option.

jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Oct 13, 2021
@derrickstolee
Merge pull request git-for-windows#438: .github: continue pestering u…
6df9339 
…ntil user upgrades

In 'git-update-git-for-windows', there is a recently_seen variable that
is loaded from Git config. This is intended to allow users to say "No, I
don't want that version of Git for Windows." If users say no, then they
are not reminded. Ever.

We want users of microsoft/git to be notified repeately until they
upgrade. The first notification might be dismissed because they don't
want to interrupt their work. They should get the picture within a few
reminders and upgrade in a timely fashion.

---

I tested this by running the `sed` command in my copy of `git-for-windows/build-extra`, and then replacing my installed version of `git-update-git-for-windows` in `C:\Program Files\Git\mingw64\bin`. Along the way, I discovered a bug in the script and created git-for-windows/build-extra#382. If you do your own testing, you will likely need that fix, too.

I also noticed a misplaced `&&` due to copying some existing scripts out of the workflow into a bash script so I could test all of the scripts simultaneously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brownp2k