Work around git scm.com https misconfiguration #1956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make a subsequent patch easier to understand, where we work around a misconfiguration of git-scm.com that won't let us enforce HTTPS in the GitHub UI at https://github.com/git/git-scm.com/settings/pages. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We do want to enforce HTTPS. And we kind of do, but not "kind of" enough for GitHub's UI at https://github.com/git/git-scm.com/settings/pages to allow us to check the box called "Enforce HTTPS". The helpful comment next to the grayed out box says: [ ] **Enforce HTTPS** --- Unavailable for your site because your domain is not properly configured to support HTTPS ([`git-scm.com`](http://git-scm.com/)) --- [Troubleshooting custom domains](https://docs.github.com/articles/troubleshooting-custom-domains/#https-errors) HTTPS provides a layer of encryption that prevents others from snooping on or tampering with traffic to your site. When HTTPS is enforced, your site will only be served over HTTPS. [Learn more about securing your GitHub Pages site with HTTPS](https://docs.github.com/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https). As discussed in git#1953, it would appear to be outside our capabilities to fix this properly, therefore we are unfortunately stuck with hard-coding a work-around: Manually override the http:// URL produced by `actions/configure-pages` with the equivalent https:// one. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
#1953