Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update japanese translation #1398

Closed
wants to merge 2 commits into from
Closed

Update japanese translation #1398

wants to merge 2 commits into from

Conversation

TakehideMorimoto
Copy link

@TakehideMorimoto TakehideMorimoto commented Dec 6, 2021

I made a Japanese translate here.

@TakehideMorimoto TakehideMorimoto marked this pull request as ready for review December 6, 2021 03:41
Copy link
Member

@flaix flaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This is awesome!

I found some issues in your files, so you may want to go over them again and make sure you have no duplicate keys, no incorrect keys and no empty definitions.

What is more, though, is a technical issue. Your changes are based on a rather old commit and then merged into your master. This way I cannot merge them. A merge request should always come from a separate branch, not from master. (And only contain the changes for one feature/topic.) So can you create a new branch on top of the current master of gitblit/gitblit and cherry-pick only the one commit 17da704 onto it? I do think that you will probably have to create a new merge request for it.

If you don't know how to do that, that is also not a problem. In that case you can also add a new commit to fix the issues and I will then create new commit from your commits for you.

Please be advised that several issues with language files have been fixed (see PR #1380), which also touched the Japanese properties file.

In any case, thank you very much for taking the time and improving the Japanase translation!

@flaix flaix added this to the 1.9.2 milestone Dec 6, 2021
@TakehideMorimoto
Copy link
Author

Sorry. I will go over some issues that you point out, and make sure keys.
And I create new branch and new merge request another day.

@flaix
Copy link
Member

flaix commented Jan 15, 2022

I have fixed the submission and added it under a new commit to the main branch.
Closing this as done.

@flaix flaix closed this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants