This repository was archived by the owner on Jan 26, 2023. It is now read-only.
WIP first draft of Python Gitcoin API client #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, looks like Travis is already set up. |
mbeacom
reviewed
May 24, 2018
gitcoin/client.py
Outdated
| import requests | ||
|
|
||
|
|
||
| class Config: | ||
| """Define Base Class for API Endpoint Config.""" | ||
| params = {} |
raphaelhuefner
changed the title
|
I shouldn't have included tests which run against the live API, I guess... I'll find a way to make them optional, so that Travis won't run them. At least now we know that my API wrapper will bubble up those 4xx and 5xx HTTP errors. ;-) |
|
@raphaelhuefner You should be able to use something like |
…ds, replace own mocks with "responses" lib
|
This PR is now obsolete, it is superseded by #3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbeacom Please do not merge this PR, but only use it to give me feedback.
Additionally, I have these questions:
requestslibrary so that it does not send any actual HTTP requests? Or do we have to fire up a complete local instance of Gitcoin to run it against?https://gitcoin.co/api/v0.1/universeAPI endpoint. I only got as far as http://django-filter.readthedocs.io/en/latest/guide/rest_framework.html#using-the-filter-fields-shortcut and that the correspondingfilter_fieldssetting is missing fromExternalBountyViewSet.Thank you!
Raphael