Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend Coding Advanced Payout Feature #1422

Closed
owocki opened this issue Jun 11, 2018 · 36 comments
Closed

Frontend Coding Advanced Payout Feature #1422

owocki opened this issue Jun 11, 2018 · 36 comments

Comments

@owocki
Copy link
Contributor

owocki commented Jun 11, 2018 •
edited by PixelantDesign
Loading

FRONT END CODING TASK

User Story

As a funder of Cooperative/Contest, I want a Bulk Payout Feature, since Cooperative/Contest Bounties don't have that currently and it'd be way more convenient.

Why Is this Needed?

Summary:
Because paying out competitive and contest blounties is way too cumbersome now.

Description

Type:
Feature

Current Behavior

Legacy Accept Flow

Expected Behavior

  1. When a bounty that is Cooperative/Contest bounty, the accept button will be replaced with a 'payout bounty' button.

screen_shot_2018-06-10_at_7_30_56_pm

  1. when i click that button, ill be presented with a form that allows me to payout the bounty to n number of github usernames (or ether addresses).

screen shot 2018-06-10 at 7 40 47 pm

html of this form, download link

the form will auto complete the 'amount' field based upon the percentages.
the form will grey out the 'payout' button until all fields add up to 100% exactly

This form will validate

  1. that the percentages in leftmost column add up to 100%
  2. all github usernames and ether addresses are valid

Upon submission,

  1. the bounty will be canceled in standard bounties (since StandardBounties doesnt contain functionality for multiple payouts as we need -- see As a funder, I want to changeBountyFulfillmentAmount() for contest/cooperative bounties, so I can pay out multiple submissions #1379 and As a funder, I want to allow the crowd to increase contributions to a bounty, so we can crowdfund issues. #1380 )
  2. the bounty will be marked as 'done' on gitcoin
  3. several new tips will be created on behalf of the funding user to payout each of the above amounts.

this may result in multiple metamask confirmations and the user should be prompted as we explain what we're doing.

Bounty

this is a bounty for the frontend coding of this interface. That means that youll be creating the links to the form from the bounty detail page AND the bulk form html / js itself, but not doing any of the heavy lifting around actually transmitting the tokens to the blockchain.

please only start work in this if you can get a WIP PR in within 24 hours and finish the task within 7 days.
@owocki owocki mentioned this issue Jun 11, 2018
Closed
@owocki
Copy link
Contributor Author

owocki commented Jun 11, 2018

@PixelantDesign thoughts on this?

@PixelantDesign
Copy link
Contributor

This is very useful and could be applied to splitting bounties on non/co op project types.

The contributor would still click to submit the work correct?

When a funder clicks Payout Bounty - will he/she see the work submission (and note) that was provided by each co-op participant? Or is the funder only concerned about paying out at this point?

I think it's nice to see submissions from each participant and show the payment form below...thoughts?

Will a funder always want to pay all coops at once? Will we allow breaking up of payment (a funder to pay for just 2 of the 4 co-op participants)?

@owocki
Copy link
Contributor Author

owocki commented Jun 11, 2018

The contributor would still click to submit the work correct?

Interesting comment about this on the Gitcoin slack

But brings up a question: If I see that I am likely not going to win a contest bounty, why pay gas to submit work? :thinking_face: So I would start work and wait and see if I am even close in the running before submitting work, right? Is that a bug or a feature of this new system? (edited)

Will a funder always want to pay all coops at once? Will we allow breaking up of payment (a funder to pay for just 2 of the 4 co-op participants)?

I'm not sure they will... we can either (1) build this first and then iterate towards multi bulk payouts or (2) add that scope to this ticket

@nuke-web3
Copy link
Contributor

I figure that as a bounty hunter this is a good thing - as I save gas if I wait to see if I have a chance at winning a competition. But in what cases is this an issue for funders? As I would need to get close to a full solution/ completion anyway to be in the running.

@nuke-web3
Copy link
Contributor

nuke-web3 commented Jun 11, 2018 •
edited
Loading

More fundamentally though - if I do the work on a funded issue, all I need to do is provide my address to a funder right? Why does it need to be on a smart contract? Just have the funder plug that directly into the contract to payout so you never need to pay as a bounty hunter to submit work. This seems like a better way to get people on-boarded for sure. No need for eth to be paid for a bounty. Am I missing something?

@owocki owocki mentioned this issue Jun 11, 2018
Open
@owocki
Copy link
Contributor Author

owocki commented Jun 11, 2018

@nukemandan thanks for your comments.. i think mbeylin and you chatted about this on slack right?

@PixelantDesign any objections if i fund the creation of this form via a bounty?

@nuke-web3
Copy link
Contributor

@owocki yes - https://gitcoincommunity.slack.com/archives/C7A4F4UHK/p1528738287000660
Ongoing there. 😀

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Jun 12, 2018 •
edited
Loading

@owocki

That is an interesting point, though having participated in coops myself, I think once the person has done the work, they've committed to entering, no? What's a little bit of gas if you've already put in the effort?Perhaps it depends on what the task is.

I think building the form out to pay out all at once to see if we get traction on it makes sense.

Let's bounty it!
I would just ask that the developer uses existing form styles currently used on the new fund issue form. or reference UI toolkit on the creative repo.

@owocki owocki changed the title As a funder of Cooperative/Contest Bounties, I want a Bulk Payout Feature, since Cooperative/Contest Bounties don't have that currently and it'd be way more convenient. Frontend Coding - As a funder of Cooperative/Contest Bounties, I want a Bulk Payout Feature, since Cooperative/Contest Bounties don't have that currently and it'd be way more convenient. Jun 12, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

This was referenced Jun 12, 2018
Closed
Closed
@PixelantDesign PixelantDesign added this to the June 2018 milestone Jun 12, 2018
@owocki
Copy link
Contributor Author

owocki commented Jun 13, 2018

@phyroxin just shot you over an approval. looking forward to working with ya!

@owocki
Copy link
Contributor Author

owocki commented Jun 13, 2018

and to answer your questions.. no special requirments.. theres repo spin up instructions at https://github.com/gitcoinco/web/

@gitcoinbot
Copy link
Member

@phyroxin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@phyroxin
Copy link

phyroxin commented Jun 18, 2018 via email

@snezanasucurovic
Copy link

I completed work on https://gitcoin.co/issue/gitcoinco/web/1422/606. I don't find out how to put my code. Please help.

@snezanasucurovic
Copy link

I put code on github, https://github.com/snezanasucurovic/snezanalounge1
I hope it is enough.

@owocki
Copy link
Contributor Author

owocki commented Jun 18, 2018

@snezanasucurovic this issue was claimed by @phyroxin -- thats why you can't claim the issue on gitcoin.

@phyroxin what do you want to do here? depending upon how far along you are... you could release the issue or continue working on it. i'd also be happy to split the payout between both of ya

@owocki
Copy link
Contributor Author

owocki commented Jun 18, 2018

cc @PixelantDesign -- this is interesting.. its the first case of someone doing work while another person had claimed the bounty (since we launched the project types PR)

@phyroxin
Copy link

phyroxin commented Jun 18, 2018 via email

@snezanasucurovic
Copy link

snezanasucurovic commented Jun 18, 2018 via email

@vs77bb
Copy link
Contributor

vs77bb commented Jun 18, 2018

Hi @snezanasucurovic, please go here to click 'Start Work' on the bounty. If you believe it's ready for submission, you may also 'Submit Work'. If you need a bit of ETH to do so, please reference the Gitcoin Faucet

@phyroxin Thank you for your understanding in this scenario and for being a team player. While we removed you from the bounty, it did not count in any way against your record. We hope you find something else to work and please let us know if you have any questions!

@phyroxin
Copy link

phyroxin commented Jun 18, 2018 via email

@gitcoinbot
Copy link
Member

gitcoinbot commented Jun 19, 2018 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 8 months, 3 weeks ago.
Please review their action plans below:

1) snezanasucurovic has been approved to start work.

I think I can submit code. I will change it according to comments.

Learn more on the Gitcoin Issue Details page.

@bockp bockp mentioned this issue Jun 19, 2018
Closed
@snezanasucurovic
Copy link

Dear Sir,
I corrected code for Add Row and Payout buttons. Do I understand ? Am I expected to correct other code ?
Kind regards,
Snezana

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

  1. @snezanasucurovic

@owocki please take a look at the submitted work:

@snezanasucurovic
Copy link

While I was submitting work I forgot to place link. Here it is https://github.com/snezanasucurovic/snezanalounge1 and file is HTMLVer2Sucurovic.html. I am not comfortable with version control systems.
Kind regards,
Snezana

@thelostone-mc
Copy link
Member

@snezanasucurovic you would have to integrate this code into this repo! add your changes on top of that so that we can check it out

Check out https://git-scm.com/videos -> they've got decent how to use git
To set up the repo : https://github.com/gitcoinco/web#running-locally

@snezanasucurovic
Copy link

snezanasucurovic commented Jun 26, 2018 via email

@mbeacom
Copy link
Contributor

mbeacom commented Jun 27, 2018

@snezanasucurovic Thank you for your contribution!

Can you migrate this into our repository gitcoinco/web? We'll need your existing implementation migrated from .html files to populate data from the Django backend and rendered via the Django templating engine.

You can take a look at: https://github.com/gitcoinco/web/tree/master/app/dashboard/templates for more examples of how our model/view/template/controller flow is handled.

Feel free to reach out to us directly on slack or on this issue for further assistance or clarification.

You can get started by setting up the local test environment as outlined in:

https://github.com/gitcoinco/web/blob/master/docs/RUNNING_LOCALLY_DOCKER.md

@snezanasucurovic
Copy link

snezanasucurovic commented Jun 28, 2018 via email

@PixelantDesign PixelantDesign modified the milestones: June 2018, July 2018 Jul 5, 2018
@PixelantDesign PixelantDesign changed the title Frontend Coding - As a funder of Cooperative/Contest Bounties, I want a Bulk Payout Feature, since Cooperative/Contest Bounties don't have that currently and it'd be way more convenient. Frontend Coding Bulk Payout Feature Jul 5, 2018
@owocki
Copy link
Contributor Author

owocki commented Jul 6, 2018

@snezanasucurovic welcome back :) mind taking a look now that youre back at the office?

@snezanasucurovic
Copy link

snezanasucurovic commented Jul 7, 2018 via email

@snezanasucurovic
Copy link

snezanasucurovic commented Jul 8, 2018 via email

@owocki owocki mentioned this issue Jul 9, 2018
Merged
12 tasks
@owocki
Copy link
Contributor Author

owocki commented Jul 10, 2018

@snezanasucurovic i'm just going to use the code as is. need this for the above PR and can't wait for you to get the repo spun up. thanks!

@owocki owocki changed the title Frontend Coding Bulk Payout Feature Frontend Coding Advanced Payout Feature Jul 11, 2018
@vs77bb
Copy link
Contributor

vs77bb commented Jul 19, 2018

@owocki can we close this one out or are you still looking for this to be done at some point?

@owocki owocki closed this as completed Jul 19, 2018
@ghost ghost removed the in progress label Jul 19, 2018
@gitcoinbot
Copy link
Member

⚡️ A tip worth 50.00000 DAI (50.0 USD @ $1.0/DAI) has been granted to @snezanasucurovic for this issue. ⚡️

Nice work @snezanasucurovic! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@PixelantDesign @owocki @phyroxin @thelostone-mc @mbeacom @vs77bb @gitcoinbot @nuke-web3 @snezanasucurovic