Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the fetch_if_missing global into a field of struct repository #251

Open
dscho opened this issue May 31, 2019 · 2 comments · May be fixed by #606
Open

Turn the fetch_if_missing global into a field of struct repository #251

dscho opened this issue May 31, 2019 · 2 comments · May be fixed by #606
Labels
good first issue Good for newcomers

Comments

@dscho
Copy link
Member

dscho commented May 31, 2019

It is high time that we reduced our globals, especially in light of finally having struct repository and working towards using it everywhere.
@dscho dscho added the good first issue Good for newcomers label May 31, 2019
@weekly-digest weekly-digest bot mentioned this issue Jun 2, 2019
Closed
@ghost
Copy link

ghost commented Sep 19, 2019

Hello Git contributors
I am Shubham Ghule.I am an engineering student.I am new to an open source and I am excited to contribute to Git.
I have tired various options to solve #251 bug and came up with a solution.This patch will convert the extern integer 'fetch_if_missing' into a field of 'struct repository'.
I would really like to submit the patch.
I am looking forward to your review.
Thanks!
Shubham Ghule.
@dscho

@dscho
Copy link
Member Author

dscho commented Sep 22, 2019

@dev-shubham1 no need to ask for permission ;-)

@harry-hov harry-hov linked a pull request Apr 8, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] removed fetch_if_missing global harry-hov/git
1 participant
@dscho