git-completion: sanitize the command names

[MrMebelMan]

When autocompleting git commands, ensure that the command name does not contain special characters.

I've found this by misspelling pull as [ull.

Steps to reproduce:

git [ <TAB>

The output is following:

bash: declare: `_git_[': not a valid identifier
error: invalid key: alias.[

[gitgitgadget]

Welcome to GitGitGadget

Hi @MrMebelMan, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

[dscho]

/allow MrMebelMan

[gitgitgadget]

User MrMebelMan is now allowed to use GitGitGadget.

[dscho]

Welcome, @MrMebelMan !

This seems like a desirable change, but the commit message probably wants to sprout some convincing arguments to that end.

Also, the commit message starts with a *, something that no other commit message in git.git has, so maybe drop that?

Further, the commit message could possibly say that yes, this patch adds some Bash'ism, but that's okay because it is in the Bash-specific part of the completions. I would do that if I were you, as the rest of Git's shell scripts is held to a pretty high (portable) standard that does not allow any Bash-specific constructs.

[MrMebelMan]

Thanks for the feedback, @dscho! I'll remove the asterisk and add the note about BASHism to the commit message as you suggested 🙏

I didn't come up with any "convincing" arguments though... I just think that it shouldn't throw an error when user misspells the command name :)

[dscho]

I didn't come up with any "convincing" arguments though... I just think that it shouldn't throw an error when user misspells the command name :)

But if you expand on that, it would be a convincing argument, no? Something along the lines "if the user specified a command name containing illegal characters, it clearly is not a Git command that they were talking about" or some such...

[MrMebelMan]

@dscho, thanks again, I think I finally got it :D I've altered the commit message as you said 🙏

[dscho]

@MrMebelMan nice!