Update: fixed typos in commit message #347
Conversation
Welcome to GitGitGadgetHi @SyntevoAlex, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests. Please make sure that this Pull Request has a good description, as it will be used as cover letter. Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:
It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code. Contributing the patchesBefore you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions. If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via: curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt |
|
@dscho Please allow the use of GitGitGadget for me |
|
/submit |
|
Submitted as pull.347.git.gitgitgadget@gmail.com |
SyntevoAlex
force-pushed
the
#0189_t0028_fixes
branch
from
d5f6f00
to
40e54cf
Compare
SyntevoAlex
changed the title
|
/submit |
|
Submitted as pull.347.v2.git.gitgitgadget@gmail.com |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
According to its name, the test is designed for UTF-16-LE-BOM. However, possibly due to copy&paste oversight, it was using UTF-32. While the test succeeds (extra \000\000 are interpreted as NUL), I myself had an unrelated problem which caused the test to fail. When analyzing the failure I was quite puzzled by the fact that the test is obviously bugged. And it seems that I'm not alone: https://public-inbox.org/git/CAH8yC8kSakS807d4jc_BtcUJOrcVT4No37AXSz=jePxhw-o9Dg@mail.gmail.com/T/#u Fix the test to follow its original intention. Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
SyntevoAlex
force-pushed
the
#0189_t0028_fixes
branch
2 times, most recently
from
f2fd3c6
to
e48ca7b
Compare
After I discovered that UTF-16-LE-BOM test was bugged, I decided that better tests are required. Possibly the best option here is to compare git results against hardcoded ground truth. The new tests also cover more interesting chars where (ANSI != UTF-8). Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
SyntevoAlex
force-pushed
the
#0189_t0028_fixes
branch
from
e48ca7b
to
e441027
Compare
|
/submit |
|
Submitted as pull.347.v3.git.gitgitgadget@gmail.com |
|
On the Git mailing list, Torsten Bögershausen wrote (reply to this): |
| @@ -40,7 +40,7 @@ test_expect_success 'setup test files' ' | |||
| printf "$text" | write_utf16 >test.utf16.raw && | |||
There was a problem hiding this comment.
On the Git mailing list, Junio C Hamano wrote (reply to this):
"Alexandr Miloslavskiy via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
>
> After I discovered that UTF-16-LE-BOM test was bugged, I decided that
s/bugged/buggy/ perhaps? Usually people do not place hidden
listening devices in tests ;-)
> better tests are required. Possibly the best option here is to compare
> git results against hardcoded ground truth.
> ...
> +test_commit_utf8_checkout_other "UTF-8" "Test =D0=A2=D0=B5=D1=81=
=D1=82" "\124\145\163\164\040\320\242\320\265\321\201\321\202"
> +test_commit_utf8_checkout_other "UTF-16LE" "Test =D0=A2=D0=B5=D1=81=
=D1=82" "\124\000\145\000\163\000\164\000\040\000\042\004\065\004\101\004=
\102\004"
> +test_commit_utf8_checkout_other "UTF-16BE" "Test =D0=A2=D0=B5=D1=81=
=D1=82" "\000\124\000\145\000\163\000\164\000\040\004\042\004\065\004\101=
\004\102"
> +test_commit_utf8_checkout_other "UTF-16LE-BOM" "Test =D0=A2=D0=B5=D1=81=
=D1=82" "\377\376\124\000\145\000\163\000\164\000\040\000\042\004\065\004=
\101\004\102\004"
> +test_commit_utf8_checkout_other "UTF-16BE-BOM" "Test =D0=A2=D0=B5=D1=81=
=D1=82" "\376\377\000\124\000\145\000\163\000\164\000\040\004\042\004\065=
\004\101\004\102"
> +test_commit_utf8_checkout_other "UTF-32LE" "Test =D0=A2=D0=B5=D1=81=
=D1=82" "\124\000\000\000\145\000\000\000\163\000\000\000\164\000\000\000=
\040\000\000\000\042\004\000\000\065\004\000\000\101\004\000\000\102\004\=
000\000"
> +test_commit_utf8_checkout_other "UTF-32BE" "Test =D0=A2=D0=B5=D1=81=
=D1=82" "\000\000\000\124\000\000\000\145\000\000\000\163\000\000\000\164=
\000\000\000\040\000\000\004\042\000\000\004\065\000\000\004\101\000\000\=
004\102"
There was a problem hiding this comment.
On the Git mailing list, Alexandr Miloslavskiy wrote (reply to this):
On 28.09.2019 6:47, Junio C Hamano wrote:
> s/bugged/buggy/ perhaps? Usually people do not place hidden
> listening devices in tests ;-)
Yes, hinting those hidden listening devices was an oversight. Thanks for
your help in putting them back undercover!
I understand that you already changed the commit message, so I'm not
submitting updated patch.
|
This branch is now known as |
|
This patch series was integrated into pu via git@e4dff99. |
|
This patch series was integrated into pu via git@7d81b61. |
|
This patch series was integrated into pu via git@88d7a0f. |
|
This patch series was integrated into pu via git@6ed56a1. |
|
This patch series was integrated into pu via git@ce68bef. |
|
This patch series was integrated into pu via git@9bef41e. |
|
This patch series was integrated into pu via git@0c7fbc6. |
|
This patch series was integrated into pu via git@a22681f. |
|
This patch series was integrated into pu via git@6b6bdcf. |
|
This patch series was integrated into pu via git@252c003. |
|
This patch series was integrated into pu via git@03171f3. |
|
This patch series was integrated into next via git@453900a. |
|
This patch series was integrated into pu via git@3a52cad. |
|
This patch series was integrated into pu via git@6ed610b. |
|
This patch series was integrated into next via git@6ed610b. |
|
This patch series was integrated into master via git@6ed610b. |
|
Closed via 6ed610b. |
Commit 1/2: t0028: fix test for UTF-16-LE-BOM
Commit 2/2: t0028: add more tests
Please refer to individual commit messages for more information.