Skip to content

Conversation

ryenus
Copy link

@ryenus ryenus commented Dec 3, 2019

This fixes unintentional duplication(s) of words, such as the the, and
can can etc. I also take the chance to make a few wording tweaks to
avoid suspicious duplication(s).

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 3, 2019

Welcome to GitGitGadget

Hi @ryenus, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the FreeNode IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you want to see what email(s) would be sent for a submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Freenode. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

@ryenus
Copy link
Author

ryenus commented Dec 3, 2019

@derrickstolee, could you please help /allow me?

@ryenus ryenus force-pushed the fix-typo branch 2 times, most recently from e786980 to 5c7b71c Compare December 3, 2019 05:52
@dscho
Copy link
Member

dscho commented Dec 3, 2019

/allow

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 3, 2019

User ryenus is now allowed to use GitGitGadget.

WARNING: ryenus has no public email address set on GitHub

@ryenus
Copy link
Author

ryenus commented Dec 3, 2019

Thank you @dscho for the comments, that all make sense.
And I've updated the commit accordingly.

@ryenus ryenus force-pushed the fix-typo branch 3 times, most recently from 39a690a to abb9e55 Compare December 5, 2019 03:01
@ryenus
Copy link
Author

ryenus commented Dec 5, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 5, 2019

Submitted as pull.482.git.1575517503.gitgitgadget@gmail.com

WARNING: ryenus has no public email address set on GitHub

Correct unintentional duplication(s) of words, such as "the the",
and "can can" etc.

The changes are only applied to cases where it's fixing what is clearly
wrong or prone to misunderstanding, as suggested by the reviewers.

Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Helped-by: Denton Liu <liu.denton@gmail.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: ryenus <ryenus@gmail.com>
@dscho
Copy link
Member

dscho commented Dec 13, 2019

Did you mean to /submit a new iteration of the patch?

@ryenus
Copy link
Author

ryenus commented Dec 15, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 15, 2019

Submitted as pull.482.v2.git.1576422744.gitgitgadget@gmail.com

WARNING: ryenus has no public email address set on GitHub

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 16, 2019

This patch series was integrated into pu via git@571fb96.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 16, 2019

This patch series was integrated into next via git@571fb96.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 16, 2019

This patch series was integrated into master via git@571fb96.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 16, 2019

Closed via 571fb96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants