prepare_shell_cmd: add code comment #574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging something else, I was quite puzzled to see that
`prepare_shell_cmd()` duplicates the command before sending to sh, like:
sh -c "git-upload-pack '../testrepo/.git'" "git-upload-pack '../testrepo/.git'"
A Windows programmer myself, initially I thought that it's a bug.
Add a clarifying comment.
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
|
/submit |
|
Submitted as pull.574.git.1583498508362.gitgitgadget@gmail.com |
|
@dscho it seems that there is a bug in |
|
Yep, it seems to be flaky. |
|
On the Git mailing list, Alexandr Miloslavskiy wrote (reply to this): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging something else, I was quite puzzled to see that
prepare_shell_cmd()duplicates the command before sending to sh, like:sh -c "git-upload-pack '../testrepo/.git'" "git-upload-pack '../testrepo/.git'"
A Windows programmer myself, initially I thought that it's a bug.
Add a clarifying comment.
Signed-off-by: Alexandr Miloslavskiy alexandr.miloslavskiy@syntevo.com