New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: add support selecting http version #69

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@fcharlie

fcharlie commented Nov 7, 2018

Usually we don't need to set libcurl to choose which version of the
HTTP protocol to use to communicate with a server.
But different versions of libcurl, the default value is not the same.

CURL >= 7.62.0: CURL_HTTP_VERSION_2TLS
CURL < 7.62: CURL_HTTP_VERSION_1_1

In order to give users the freedom to control the HTTP version,
we need to add a setting to choose which HTTP version to use.

This patch support force enable HTTP/2 or HTTP/1.1.

example:

GIT_CURL_VERBOSE=1 git2 -c http.version=HTTP/2 ls-remote https://bitbucket.org/aquariusjay/deeplab-public-ver2.git

@fcharlie fcharlie force-pushed the fcharlie:master branch 2 times, most recently from 8b0bead to 4f5a935 Nov 7, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 7, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 7, 2018

An error occurred while submitting:

Error: Permission denied for user fcharlie

@fcharlie

This comment has been minimized.

fcharlie commented Nov 7, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 7, 2018

An error occurred while submitting:

Error: Permission denied for user fcharlie

@dscho

This comment has been minimized.

dscho commented Nov 7, 2018

/allow fcharlie

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 7, 2018

User fcharlie is now allowed to use GitGitGadget.

@dscho

This comment has been minimized.

dscho commented Nov 7, 2018

@fcharlie could you try again, please?

@fcharlie

This comment has been minimized.

fcharlie commented Nov 7, 2018

/submit

@fcharlie

This comment has been minimized.

fcharlie commented Nov 7, 2018

@dscho thanks

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 7, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 8, 2018

@fcharlie fcharlie force-pushed the fcharlie:master branch from 93ecd72 to ef975b6 Nov 8, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 8, 2018

@fcharlie fcharlie force-pushed the fcharlie:master branch from ef975b6 to 0a77947 Nov 8, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 8, 2018

@fcharlie fcharlie force-pushed the fcharlie:master branch from 0a77947 to cdd9304 Nov 8, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 8, 2018

@fcharlie fcharlie force-pushed the fcharlie:master branch 2 times, most recently from bc52d2a to 93fda67 Nov 8, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 8, 2018

@fcharlie fcharlie force-pushed the fcharlie:master branch from 93fda67 to e26fc0d Nov 8, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 8, 2018

http: add support selecting http version
Usually we don't need to set libcurl to choose which version of the
HTTP protocol to use to communicate with a server.
But different versions of libcurl, the default value is not the same.

CURL >= 7.62.0: CURL_HTTP_VERSION_2TLS
CURL < 7.62: CURL_HTTP_VERSION_1_1

In order to give users the freedom to control the HTTP version,
we need to add a setting to choose which HTTP version to use.

Signed-off-by: Force Charlie <charlieio@outlook.com>

@fcharlie fcharlie force-pushed the fcharlie:master branch from e26fc0d to 71f8b71 Nov 9, 2018

@fcharlie

This comment has been minimized.

fcharlie commented Nov 9, 2018

/submit

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Nov 9, 2018

This comment was marked as outdated.

dscho commented Dec 14, 2018 — with GitGitGadget

This branch is now known as fc/http-version.

This comment was marked as outdated.

dscho commented Dec 14, 2018 — with GitGitGadget

This patch series was integrated into pu via git@5869094.

This comment was marked as outdated.

dscho commented Dec 14, 2018 — with GitGitGadget

This patch series was integrated into next via git@42f5155.

@dscho dscho added next pu labels Dec 14, 2018 — with GitGitGadget

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Dec 14, 2018

This branch is now known as fc/http-version.

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Dec 14, 2018

This patch series was integrated into pu via git@5869094.

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Dec 14, 2018

This patch series was integrated into next via git@42f5155.

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Dec 15, 2018

This branch is now known as fc/http-version.

@gitgitgadget

This comment has been minimized.

gitgitgadget bot commented Dec 15, 2018

This patch series was integrated into pu via git@4c45cd9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment