Fix regression in t9902 with NO_PERL #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/submit |
|
Submitted as pull.99.git.gitgitgadget@gmail.com |
dscho
force-pushed
the
t9902-no-perl-fix
branch
from
32e6bf2 to
2a055a3
Compare
The oneline notwithstanding, 1337498 (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers. Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
t9902-no-perl-fix
branch
from
2a055a3 to
8e3ddff
Compare
|
/submit |
|
Submitted as pull.99.v2.git.gitgitgadget@gmail.com |
|
This branch is now known as |
|
This patch series was integrated into pu via git@6be6e66. |
|
This patch series was integrated into next via git@6be6e66. |
|
This patch series was integrated into master via git@6be6e66. |
|
This patch series was integrated into maint via git@6be6e66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oneline notwithstanding, 1337498 (completion: use __gitcomp_builtin for format-patch, 2018-11-03) changed also the way
send-emailoptions are completed, by asking thegit send-emailcommand itself what options it offers.Necessarily, this must fail when built with
NO_PERLbecausesend-emailitself is a Perl script. Which means that we need the PERL prerequisite for thesend-emailtest case in t9902.Changes since v1: