Skip to content

pr-2270/rogerkorantenng/mktree-batch-tests-v2

tagged this 10 Nov 22:13
From: Roger Koranteng <rogerkorantenng@gmail.com>

The only "mktree --batch" test in t1010 is the one checking that it
survives a concurrent repack. Nothing covers basic batch mode, which
is how the leak fixed in 6272f3bd17 (mktree: plug per-tree leak in
--batch mode, 2026-08-29) went unnoticed.

Add a few tests for it. Two trees in one batch should get the same
IDs as running plain "mktree" on each, a trailing blank line should
not add an extra tree, -z input should work, and a tree that names a
missing object should make mktree die after printing the trees before
it. While at it, check that a blank line is rejected without --batch.

Suggested-by: Jeff King <peff@peff.net>
Tested-by: Laveesh Bansal <laveeshb@laveeshbansal.com>
Signed-off-by: Roger Koranteng <rogerkorantenng@gmail.com>

Submitted-As: https://lore.kernel.org/git/pull.2270.v2.git.1794348807240.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.2270.git.1792497283164.gitgitgadget@gmail.com
Assets 2
Loading