Skip to content

pr-2323/marinelay/fast-import-inline-eof-v1

tagged this 21 Nov 07:40
From: Wonseok Oh <marinelay7@gmail.com>

If `M <mode> inline <path>` appears at the end of input,
file_change_m() exits its read loop on EOF without reading a `data`
command. It then puts an uninitialized stack object ID into the tree
and exits 0, leaving a tree entry for a missing blob that `git fsck`
flags.

note_change_n() avoids this by calling parse_and_store_blob() at EOF,
which dies on the missing `data` command. Do the same in
file_change_m(), and add a test.

Signed-off-by: Wonseok Oh <marinelay7@gmail.com>

Submitted-As: https://lore.kernel.org/git/pull.2323.git.1795246845186.gitgitgadget@gmail.com
Assets 2
Loading