Extension should be installed in Assets/Plugins/GitHub folder

[shana]

Related to github-beta/unity-preview#19. We're currently installing into Editor\GitHub, which causes two problems:

1. There's a high probability that another plugin will have an Editor folder in the root. This can cause conflicts with meta files between both plugins
2. It's hard to encapsulate the extension inside a common folder in the current structure. If it's in GitHub, then we can have whatever we need in there and not worry about side effects or things spilling out (like meta files or gitignore files.

Update: Putting it in Assets/Plugins instead

[ericdrobinson]

If you haven't seen this yet, I would highly recommend taking a look at the "Where to Install Your Assets (for Scripting Packages/Editor Extensions)" thread in the Unity forums.

Seeing as how you are delivering nothing more than DLLs (beyond the PlatformResources), I would suggest that you move the main installation folder to the following location:

Assets/Plugins/GitHub

Some reasoning:

1. You should not need the Editor folder in the tree as everything is shipped as DLLs. The Editor folder is for scripts (and, with recent versions of Unity, some Resources content). DLL content is only included in a build if it is referenced by runtime scripts or content.
2. Adding it to the Assets/Plugins folder is a fairly standard approach. Many compliant extensions do this (some have to for the script compilation order benefits).
3. It communicates the fact that the GitHub content is, indeed, a Plugin (extension).

[shana]

@ericdrobinson Thanks for the pointer, that makes sense and I had completely forgotten about the little compilation order detail. We'll move things around.

[thorade]

Note: One also has to update the .gitignore file!