NullReferenceException: Object reference not set to an instance of an object

[GalHorowitz]

Prerequisites

• Be sure to run with tracing enabled to capture runtime details in the log file
• Include the log file in the PR.
  • On Windows, the extension log file is at %LOCALAPPDATA%\GitHubUnity\github-unity.log
  • On macOS, the extension log file is at ~/Library/Application Support/GitHubUnity/github-unity.log

Description

Right after installing the extenstion, and opening the Github Window the console is spammed with errors and the window is blank. The settings window works tho.

Steps to Reproduce

1. [First Step]
   Install Github for Unity
2. [Second Step]
   Open the Github Window
3. [and so on...]
   Look at console

Expected behavior: [What you expect to happen]
For the window to show up with no errors
Actual behavior: [What actually happens]
The window is blank and there are errors
Reproduces how often: [What percentage of the time does it reproduce?]
100% of the time

Additional Information

I have Unity 2017.2.0b5 (64-bit) and the latest Github for Unity release.
Any additional information, configuration or data that might be necessary to reproduce the issue.
github-unity.log

[StanleyGoldman]

hey @GalHorowitz thanks for testing!

So this is one of those bugs where I'm not going to get the information we need through our log file.
I need you to copy and paste the full log message from the console in Unity that gave you this message...

[GalHorowitz]

No, thank you @StanleyGoldman for making this!

NullReferenceException: Object reference not set to an instance of an object
GitHub.Unity.StreamExtensions.<StreamExtensions>m__3 (UnityEngine.Texture2D tex, System.IO.MemoryStream ms) (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs:173)
GitHub.Unity.StreamExtensions.ToTexture2D (System.IO.Stream input) (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs:191)
GitHub.Unity.Utility.GetIcon (System.String filename, System.String filename2x) (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs:78)
GitHub.Unity.Styles.get_BigLogo () (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Styles.cs:694)
GitHub.Unity.InitProjectView.OnGUI () (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs:42)
GitHub.Unity.Window.OnUI () (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs:178)
GitHub.Unity.BaseWindow.OnGUI () (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BaseWindow.cs:88)
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:232)
System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MethodBase.cs:115)
UnityEditor.HostView.Invoke (System.String methodName, System.Object obj) (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:283)
UnityEditor.HostView.Invoke (System.String methodName) (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:276)
UnityEditor.HostView.InvokeOnGUI (Rect onGUIPosition) (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:243)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

[GalHorowitz]

I noticed another error:

NullReferenceException: Object reference not set to an instance of an object
GitHub.Unity.StreamExtensions.<StreamExtensions>m__3 (UnityEngine.Texture2D tex, System.IO.MemoryStream ms) (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs:173)
GitHub.Unity.StreamExtensions.ToTexture2D (System.IO.Stream input) (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs:191)
GitHub.Unity.Utility.GetIcon (System.String filename, System.String filename2x) (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs:78)
GitHub.Unity.Styles.get_SmallLogo () (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Styles.cs:681)
GitHub.Unity.Window.OnEnable () (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs:95)
UnityEditor.EditorWindow:GetWindow(Type[])
GitHub.Unity.Window:ShowWindow(IApplicationManager) (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs:62)
GitHub.Unity.Window:GitHub_ShowWindow() (at C:/Users/Spade/Projects/GitHub/Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs:50)

[StanleyGoldman]

Thanks @GalHorowitz this is what we needed.

[GalHorowitz]

Is there any way to subscribe to notifications about this issue, so I would know when it's fixed?

[shiena]

I think that this change is affected.
https://unity3d.com/jp/unity/whats-new/unity-2017.2.0

Backwards Compatibility Breaking Changes

• Scripting: UnityEngine.dll is now split into separate dlls for each UnityEngine module.

So, it seems to be solved in this way.
http://answers.unity3d.com/questions/206665/typegettypestring-does-not-work-in-unity.html

diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs
index e645e565..0deb4c97 100644
--- a/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs
+++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs
@@ -32,7 +32,7 @@ namespace GitHub.Unity

         static StreamExtensions()
         {
-            var t = typeof(Texture2D).Assembly.GetType("UnityEngine.ImageConversion", false, false);
+            var t = Assembly.Load("UnityEngine.dll").GetType("UnityEngine.ImageConversion", false, false);
             if (t != null)
             {
                 // looking for ImageConversion.LoadImage(this Texture2D tex, byte[] data)

[shana]

shakes fist at Unity

Ok so the problem is that ImageConversion got moved out to a separate DLL, which means using Texture2D as a DLL location base no longer works. Worse, it got moved to its own assembly - literally a DLL which only contains this class, which means there is no type we can use to get at its location. So, sigh, we'll need to add yet another codepath to the StreamExtensions code to reference the UnityEngine.ImageConversionModule.dll dll and get the ImageConversion type.

[joegoldin]

Any idea when this will be fixed in release? Thanks!

[jennykortina]

+1 on this, would love to get this fixed. Thank you!

[StanleyGoldman]

We appreciate the love guys.

\

We are just busy chasing other stability issues at the moment.
Hopefully in a few weeks we can get to this.