Command Line not showing

[ThomasAunvik]

Description

When trying to open the command line from Unity via this plugin

Steps to Reproduce

1. Open Unity 2017.3.0f3 and create a new project (does not have to be a new project)
2. Install Github for Unity (unless you already have github for unity)
3. Go to Github > Command line
4. Expect something to not work.

Expected behavior: To show this for example:

I managed to get this via File Explorer and typing cmd in the file path.

Actual behavior: Nothing shows on the console, unable to type in the console either.
The image above in description.

Reproduces how often: 100% prob

Additional Information

Default configuration with trace logging
Gist log: https://gist.github.com/ThomasAunvik/697d655743168aa6596cc652a233efdd

[meaghanlewis]

Hi @ThomasAunvik thanks for reporting this detailed issue. I just tried to repo this issue myself on Windows using the Unity 2017.0f3 with GitHub for Unity version 0.26.2, but was unable to do so. The terminal window opens just fine for me.

You mentioned this is probably reproducible 100% of the time. Have you tried this again and if so, do you continue to the experience same result every time?

[ThomasAunvik]

I have tried creating a new project folder and testing it, i will see if i can debug it.

[ThomasAunvik]

Alright, so i deleted the GitHubUnity folder in AppData, and it still did not work.

[StanleyGoldman]

Hey @ThomasAunvik after I debug some more pressing issues. I can take a look at this with you.

[StanleyGoldman]

Hey @ThomasAunvik can you see if you can reproduce this bug with the latest beta version?

[shana]

This should be fixed with the latest beta - if it isn't, please feel free to reopen!

[ThomasAunvik]

Sorry, still not fixed, it works for my laptop though, weird bug.

[ThomasAunvik]

1. Temporary Fix: Reimport All assets. (Right click in Project window and press Reimport All)
2. (Sometimes) After rebooting unity (after reimport): Command line closes immidiately after trying to open it.
3. Rebooting again: Command line shows as the original issue.

[ThomasAunvik]

It seems that there is something wrong with how either the code's configuration is set up, or how my environmental variables are weird.

Setting this to true.

Unity/src/GitHub.Api/OutputProcessors/ProcessManager.cs

Line 70 in 7d188de

UseShellExecute = false,

And commenting this line out:

Unity/src/GitHub.Api/OutputProcessors/ProcessManager.cs

Line 77 in 7d188de

gitEnvironment.Configure(startInfo, workingDirectory);

Fixes the issue, but i am sure that is not how its intended to be.