This repository was archived by the owner on Dec 5, 2024. It is now read-only.
A dedicated view to initialize the project #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2017
Merged
5 tasks
StanleyGoldman
force-pushed
the
enhancements/initialize-view
branch
2 times, most recently
from
0fb1ba8 to
29cc836
Compare
StanleyGoldman
force-pushed
the
enhancements/initialize-view
branch
from
f36423e to
97608d6
Compare
StanleyGoldman
commented
Sep 8, 2017
| @@ -0,0 +1,467 @@ | |||
| #pragma warning disable 649 | |||
2 tasks
shana
changed the title
# Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj
StanleyGoldman
force-pushed
the
enhancements/initialize-view
branch
from
181e0e2 to
df2e7ee
Compare
…s/initialize-view # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj
shana
reviewed
Sep 20, 2017
| @@ -158,6 +162,12 @@ public override void OnUI() | |||
|
|
|||
| DoToolbarGUI(); | |||
|
|
|||
| if (nextTab.HasValue) | |||
| { | |||
| SetActiveTab(nextTab.Value); | |||
There was a problem hiding this comment.
This probably shouldn't be done here. We should probably be saving the tab option and triggering a Redraw to do the switch in OnDataUpdate. As it stands we're calling OnDataUpdate on the old view, and never on the new view, since that event has already happened by the time we switch here.
TL;DR, the order of events for child views should be "OnDisable" (the old one) -> "OnEnable" (the new one) -> "OnDataUpdate" -> "OnGUI"
shana
suggested changes
Sep 20, 2017
| @@ -24,8 +25,10 @@ class Window : BaseWindow | |||
| private const string Window_RepoBranchTooltip = "Active branch"; | |||
|
|
|||
| [NonSerialized] private double notificationClearTime = -1; | |||
| [SerializeField] private SubTab? nextTab; | |||
There was a problem hiding this comment.
SubTab is an enum so there's no reason to use a nullable here, just add a None option to it to know what there is no current selection.
shana
reviewed
Sep 20, 2017
| case SubTab.Branches: | ||
| return branchesView; | ||
|
|
There was a problem hiding this comment.
Why the extra space? Seems like a useless change.
shana
reviewed
Sep 20, 2017
| case SubTab.Changes: | ||
| return changesView; | ||
|
|
shana
reviewed
Sep 20, 2017
| case SubTab.History: | ||
| return historyView; | ||
|
|
…alize-view-thing Cleanup the switching of the tabs
shana
approved these changes
Sep 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #251
Depends on:
Before:
After:
