This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix to correctly update LFS lock status #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
suggested changes
Sep 12, 2017
| @@ -22,6 +22,8 @@ class ProjectWindowInterface : AssetPostprocessor | |||
|
|
|||
| public static void Initialize(IRepository repo) | |||
| { | |||
| Logger.Trace("Initialize HasRespository:{0}", repo != null); | |||
| } | ||
|
|
||
| private static void RunStatusUpdateOnMainThread(GitStatus update) | ||
| { | ||
| EntryPoint.ApplicationManager.TaskManager.ScheduleUI(new ActionTask(EntryPoint.ApplicationManager.TaskManager.Token, _ => OnStatusUpdate(update))); | ||
| new ActionTask(EntryPoint.ApplicationManager.TaskManager.Token, _ => OnStatusUpdate(update)) | ||
| .ScheduleUI(EntryPoint.ApplicationManager.TaskManager); |
There was a problem hiding this comment.
IF you're changing this to a new ActionTask, then it should be new ActionTask(...) { Affinity = TaskAffinity.UI }.Start(), otherwise there's no point in making this change.
There was a problem hiding this comment.
Should I update this section as well
shana
approved these changes
Sep 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
Depends on:
Making sure favorites is not null #295
ListLocks task was not correctly strung together
There was a missing refresh for the project window