Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Throw if the manager isn't ready so that windows use their cached data instead #333

Merged
merged 4 commits into from
Oct 19, 2017

Conversation

shana
Copy link
Member

@shana shana commented Sep 20, 2017

If let's say the history view is open when Unity reloads the domain, it will call Repository.Log, which might happen before the RepositoryManager is actually initialized, which would make the Log method return an empty list, and so the history view would wipe out its serialized data and show an empty list until everything else came up. We want to keep showing the serialized UI until we get information otherwise, so if there's no repository manager we really want to throw to make sure the task chain fails.

@StanleyGoldman
Copy link
Contributor

I notice the effect most in that I can enter/exit play mode without seeing the history view clear and repopulate.
Awesome.

@StanleyGoldman StanleyGoldman merged commit 75989da into master Oct 19, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/we-like-exceptions branch October 19, 2017 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants