This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix to Unity 2017.1 .Net 4.6 #336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The correct way to do a hotfix release for 0.21 is to create two branches - one for the hotfix release, another for the hotfix itself. Bump the version on the release branch, and do the patch separately (without the version bump). Then we can do a PR of the patch onto the release branch, and we can do another PR of the same patch branch to master without having to worry about version conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #334
Initially for #145 in #310 I went to remove these regex expressions as they are not used.
Testing that, it worked.
I went back and tried to fix the stored procedures.
Resharper believed
\_to be incorrect. Expresso (a .net regex tool) didn't seem to mind it.I assumed that was the error and changed it to
_. After that I failed to test appropriately.