Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Removing regex expressions that crash Unity #342

Merged
merged 4 commits into from
Oct 10, 2017

Conversation

shana
Copy link
Member

@shana shana commented Sep 21, 2017

Fixes #334

From #335:

Initially for #145 in #310 I went to remove these regex expressions as they are not used.
Testing that, it worked.
I went back and tried to fix the stored procedures.
Resharper believed _ to be incorrect. Expresso (a .net regex tool) didn't seem to mind it.
I assumed that was the error and changed it to _. After that I failed to test appropriately.

@StanleyGoldman
Copy link
Contributor

I'll create an example repository and a bug for people at Unity to diagnose..

@StanleyGoldman
Copy link
Contributor

A lot of the regular expressions and functions in that class are not being used...
Do we want to clean that up?

@shana
Copy link
Member Author

shana commented Sep 21, 2017

Yeah, we should probably throw away all that code, we don't need it anymore.

@github-for-unity github-for-unity deleted a comment from shana Oct 10, 2017
@github-for-unity github-for-unity deleted a comment from shana Oct 10, 2017
@github-for-unity github-for-unity deleted a comment from shana Oct 10, 2017
@github-for-unity github-for-unity deleted a comment from shana Oct 10, 2017
@StanleyGoldman
Copy link
Contributor

I deleted some test comments @shana

@StanleyGoldman StanleyGoldman merged commit 07aba6a into master Oct 10, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/334-backport-regex-compilation-bleh branch October 10, 2017 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions on 2017.1 in .Net 4.6
2 participants