This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Serializing DateTimeOffset objects with ISO8601 #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
approved these changes
Nov 20, 2017
Failure to do so will lead to inconsistent results, especially with users that have a custom system-wide date time string.
StanleyGoldman
force-pushed
the
fixes/cache-date-time
branch
from
5cbf07f to
60a90b2
Compare
jcansdale
reviewed
Nov 20, 2017
|
You also removed using Octokit in this PR. Any reason for that? |
|
@jcansdale That does not enforce the ISO8601 format. From what I understand if you do not set a format you end up with your system global format. Which in the case of some users, like @shana, who prefer a 24-Hour time format, this leads to an output that is not among the formats that are parsed for by default. |
|
@sguthals It was not intentional. I think Resharper removed it, but the namespace was not used so it's a null change. |
|
Looks good! |
StanleyGoldman
force-pushed
the
fixes/cache-date-time
branch
from
1ed3d04 to
65e1a0d
Compare
This was referenced Nov 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #447
Cache objects were being serialized with their date times just being
ToStringd.This works fine most of the time, but of course it is not consistent.