This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Functionality to mark folder nodes as "root" #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
15 tasks
StanleyGoldman
changed the title
StanleyGoldman
changed the title
2 tasks
StanleyGoldman
changed the base branch from
master
to
enhancements/branches-view-rollup
drguthals
reviewed
Nov 29, 2017
| treeLocals.NodeIcon = Styles.BranchIcon; | ||
| treeLocals.FolderIcon = Styles.FolderIcon; | ||
|
|
||
| treeRemotes = new Tree(); |
There was a problem hiding this comment.
treeLocals and treeRemotes are always either defined or null together right? It isn't worth having a separate if for treeRemotes?
There was a problem hiding this comment.
They always get instantiated together, so I figured I could save the boolean check.
| @@ -383,7 +385,7 @@ private void ResetNodeIcons(TreeNode node) | |||
| } | |||
| else if (node.IsFolder) | |||
| { | |||
| if (node.Level == 1) | |||
| if (node.Level == RootFolderIconLevel) | |||
There was a problem hiding this comment.
You know what. It's a rudimentary fix for something that i'm already having to change.
I'm going to send a PR before this one that provides a correct solution instead.
…ixes/branches-view-globe-icon
StanleyGoldman
force-pushed
the
fixes/branches-view-globe-icon
branch
from
3d80dc3 to
3dcc13e
Compare
…ixes/branches-view-globe-icon
…anches-view-globe-icon # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BranchesView.cs # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/TreeControl.cs
…ixes/branches-view-globe-icon # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/TreeControl.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This branch targets
enhancements/branches-view-rollup#464Fixes #454
Depends on: