This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Properly identifying GitRemote.Default #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM 👍 |
After a domain reload strings are empty not null
StanleyGoldman
force-pushed
the
fixes/empty-publish
branch
from
7da56f8 to
39a6996
Compare
drguthals
suggested changes
Dec 1, 2017
|
Updated |
drguthals
approved these changes
Dec 1, 2017
jcansdale
approved these changes
Dec 1, 2017
StanleyGoldman
changed the title
StanleyGoldman
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
Changing how
GitRemote.Defaultis defined.Unity has issues serializing "NULL". For instance, null strings actually get serialized as empty.
We use a lot of structs.
In order to to help us identify a null struct, we use the Null Object Pattern.
Our default object for GitRemote was not correctly defined.
Some strings were null when they should be empty, in order to properly identify it as
Defaultafter deserialization.