Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Updating LFS locks list after lock operation #488

Merged
merged 7 commits into from
Dec 1, 2017
Merged

Updating LFS locks list after lock operation #488

merged 7 commits into from
Dec 1, 2017

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Nov 30, 2017 •
edited
Loading

Fixes #480

  • Added hook for locks updated event
  • Added check for current remote url before checking for locks
  • Added explicit check for locks after lock operation
  • Added a missing null check

@meaghanlewis
Copy link
Contributor

This LGTM

@jcansdale jcansdale self-requested a review December 1, 2017 13:17
jcansdale
jcansdale approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. 👍

@StanleyGoldman StanleyGoldman merged commit 44652ab into master Dec 1, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/lfs-locks-update branch December 1, 2017 15:22
@StanleyGoldman StanleyGoldman restored the fixes/lfs-locks-update branch December 1, 2017 19:48
@StanleyGoldman StanleyGoldman deleted the fixes/lfs-locks-update branch December 1, 2017 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@drguthals drguthals drguthals approved these changes

@jcansdale jcansdale jcansdale approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StanleyGoldman @meaghanlewis @drguthals @jcansdale