Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Changes view reload #505

Merged
merged 3 commits into from
Dec 5, 2017
Merged

Changes view reload #505

merged 3 commits into from
Dec 5, 2017

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 5, 2017 •
edited
Loading

  • Until the changes list serialized properly in a tree that supports serialization we need to rebuild the tree OnEnable. The proper fix for this comes in Changes TreeView Rollup #471
  • Repository is not null by the time ChangesView is active
  • Renaming a boolean to be more specific to it's purpose

Depends on:

@StanleyGoldman
Merge branch 'fixes/split-status-cache' into fixes/changes-view-reload
9d6aa66
@StanleyGoldman
Reloading the ChangesTree for domain reloads
eb2098e 
Until the changes are properly serialized in a tree that supports
serializtion we need to rebuild the tree OnEnable
drguthals
drguthals approved these changes Dec 5, 2017
View reviewed changes
Copy link

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@StanleyGoldman StanleyGoldman merged commit 34451c1 into master Dec 5, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/changes-view-reload branch December 5, 2017 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grokys grokys Awaiting requested review from grokys

@jcansdale jcansdale Awaiting requested review from jcansdale

1 more reviewer

@drguthals drguthals drguthals approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanleyGoldman @drguthals