This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Refactoring history display into HistoryControl #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanleyGoldman
changed the base branch from
master
to
enhancements/history-detail-tree-view-rollup
StanleyGoldman
force-pushed
the
enhancements/history-list-view
branch
from
e5c905f to
6090cd8
Compare
StanleyGoldman
changed the title
…ncements/history-list-view
…ncements/history-list-view # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesView.cs
drguthals
approved these changes
Dec 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR targets
enhancements/history-detail-tree-view-rollup#528Fixes: #180
The
HistoryViewimplemented a lot of functionality to handle virtual scrolling that was different to how they were approached in theTreecontrol. It was also hard to isolate code that handled the log from the code that handled the log entries.In order to resolve this I refactored the
HistoryView's handling of the list toHistoryControl.Before:
After:
