Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Preventing cache invalidation loop #531

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Preventing cache invalidation loop #531

merged 2 commits into from
Dec 13, 2017

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 13, 2017 •
edited
Loading 

if (InitializedAt == DateTimeOffset.MinValue)
{
    InitializedAt = now;
}

This check in SaveData() to update IniitliazedAt is incorrect. It causes a vicious data invalidation loop which cripples things.

I've standardized the initialization check in a property and used that.

@StanleyGoldman StanleyGoldman merged commit f91c428 into master Dec 13, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/cache-invalidation-loop branch December 13, 2017 20:17
drguthals
drguthals reviewed Dec 13, 2017
View reviewed changes
Copy link

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcansdale jcansdale Awaiting requested review from jcansdale

2 more reviewers

@drguthals drguthals drguthals left review comments

@grokys grokys grokys approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanleyGoldman @drguthals @grokys