This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Download Functionality #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanleyGoldman
changed the base branch from
master
to
enhancements/download-manager-rollup
StanleyGoldman
force-pushed
the
enhancements/download-functionality
branch
from
e477a8c to
7c10c35
Compare
StanleyGoldman
changed the base branch from
enhancements/download-manager-rollup
to
master
StanleyGoldman
changed the base branch from
master
to
enhancements/download-manager-rollup
StanleyGoldman
force-pushed
the
enhancements/download-functionality
branch
from
78841dc to
3b3debf
Compare
StanleyGoldman
changed the base branch from
enhancements/download-manager-rollup
to
enhancements/async-git-setup-rollup
…download-functionality
StanleyGoldman
force-pushed
the
enhancements/download-functionality
branch
from
c6f94f7 to
7c94cd0
Compare
StanleyGoldman
force-pushed
the
enhancements/download-functionality
branch
from
9768ed8 to
7ea50e5
Compare
StanleyGoldman
requested review from
shana,
drguthals,
grokys and
jcansdale
and removed request for
shana
drguthals
approved these changes
Jan 4, 2018
| if (bytesRead > 0) | ||
| { | ||
| destination.Write(buffer, 0, bytesRead); | ||
| if (trackProgress) |
There was a problem hiding this comment.
This if-statement is just figuring out how long it took to download, correct?
There was a problem hiding this comment.
That code is attempting to figure out the progress of the download in real time.
But my tests of the progress reporting has shown me it's less accurate that one would like.
I'm not using it now, but I will record an issue to address it because I would like to use it soon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This pull request targets
enhancements/async-git-setup-rollup#561DownloadTaskDownloadTestTask