Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Functionality to download portable git #562

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Jan 4, 2018

Note: This pull request targets enhancements/async-git-setup-rollup #561

  • Removing functionality from GitInstaller to locate zip files from local assemblies
  • Added functionality to GitInstaller
    • Ability to specify local paths to zip files for install
    • If local paths are not specified, GitInstaller pre-pends a DownloadTask to the UnzipTask
  • Added functionality to unit tests to local zip files from local assemblies, as we don't need tests downloading files we have locally.

…wnload

# Conflicts:
#	GitHub.Unity.sln.DotSettings
…up-download

# Conflicts:
#	src/GitHub.Api/Installer/GitInstaller.cs
#	src/tests/IntegrationTests/Git/GitSetupTests.cs
…up-download

# Conflicts:
#	src/GitHub.Api/Application/ApplicationManagerBase.cs
#	src/GitHub.Api/Installer/PortableGitInstallTask.cs
#	src/tests/IntegrationTests/BasePlatformIntegrationTest.cs
#	src/tests/IntegrationTests/Installer/PortableGitInstallTaskTests.cs
…up-download

# Conflicts:
#	src/tests/IntegrationTests/BasePlatformIntegrationTest.cs
…up-download

# Conflicts:
#	src/tests/IntegrationTests/Git/GitSetupTests.cs
…up-download

# Conflicts:
#	src/GitHub.Api/Installer/GitInstaller.cs
#	src/tests/IntegrationTests/BasePlatformIntegrationTest.cs
#	src/tests/IntegrationTests/Download/DownloadTaskTests.cs
@StanleyGoldman StanleyGoldman changed the title Enhancements/git setup download Functionality to download portable git Jan 10, 2018
@StanleyGoldman StanleyGoldman mentioned this pull request Jan 10, 2018
7 tasks
Copy link

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanleyGoldman StanleyGoldman merged commit 9e424f6 into enhancements/async-git-setup-rollup Jan 12, 2018
@StanleyGoldman StanleyGoldman deleted the enhancements/git-setup-download branch January 12, 2018 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants