This repository was archived by the owner on Dec 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 445
Download cancellation and progress reporting #575
Merged
shana
merged 30 commits into
enhancements/async-git-setup-rollup
from
shana/async-rollup-fixes
Feb 6, 2018
Merged
Download cancellation and progress reporting #575
shana
merged 30 commits into
enhancements/async-git-setup-rollup
from
shana/async-rollup-fixes
Feb 6, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f55e12
to
c8b9737
Compare
Also move the GitHub.Logging assembly to its own namespace so that it's easy to filter out when dumping stacktraces
4b5939d
to
6912577
Compare
…g class to LogHelper to avoid conflicts
Kill some unused code in the task system, mainly the Defer paths which we aren't using anymore Add a way of calling different tasks depending on the success or failure of the previous task. Add some different ways of setting the result of a task beyond the value returned by the previous task, mainly for seeding initial values.
GitHub.Logging naming fixes
Make it possible to branch out on task success and failure. Cleanups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally
in-thread handler - it wasn't getting called in all situations, which made things hang sometimes (namely when callingStartAwait
).GitHub.Unity.Logs
so that it's easy to filter them out when outputting caller stacktracesApplicationConfiguration
(renamed fromAppConfiguration
for clarity), so we can tweak it during testing.System.IProgress<>
interface is suited for a push model where the consumer sends in aIProgress
object to be notified of changes (which might be useful for global progress notification), which doesn't suit our chaining callback system very well. The implementation in Rackspace.Threading does aPost
to the main thread, so we really shouldn't be using it in our threaded model.