New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Enter/Return as confirm keys in authentication flow. #58

Merged
merged 2 commits into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
@CapnRat
Collaborator

CapnRat commented Jun 28, 2017

Description of the Change

Change to make Enter/Return be used as confirmation keys in the authentication window flow. Enter/Return will have the same behavior as the "Sign In" button in Username/Password state, and "Verify" button in 2FA state.

Alternate Designs

None

Benefits

UX expectation when working with form-like interfaces.

Possible Drawbacks

Possible future consideration. The way this is being handled is checking for enter/return at the beginning of OnGUI, which consumes the event before the rest of the window can process it. We do this because we want to intercept the event before the textfields do. With the current flow it's not a problem, but if the flow changed in a way where a control would want to receive enter/return, then we'd need to change how this works.

Applicable Issues

N/A

@shana

shana approved these changes Jun 29, 2017

Not having enter work on this window has been annoying me so much, thank you!

@StanleyGoldman StanleyGoldman merged commit e278e1b into github-for-unity:master Jun 29, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment