This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Switch NPath to a struct and move (I)FileSystem.cs into it. Fix some bugs #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes NPath into a struct, which requires a few adjustments to the codebase, and I stumbled onto a couple of bugs in the process, so fixed that as well. Moved the IFileSystem interface into the class file so it's easier to add things to both.
StanleyGoldman
approved these changes
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes NPath into a struct, which requires a few adjustments to the codebase, and I stumbled onto a couple of bugs in the process, so fixed that as well.
This also moves IFilesystem into the class file 'cause it's really annoying to keep them in sync otherwise when you're not in VS with resharper.