GitInstaller should prefer local resources before downloading #590
Conversation
| gitArchiveFilePath = AssemblyResources.ToFile(ResourceType.Platform, "git.zip", archiveParentPath, environment); | ||
| if (!gitArchiveFilePath.FileExists()) | ||
| { | ||
| gitArchiveFilePath = null; |
There was a problem hiding this comment.
Should this file exists check be moved into AssemblyResources.ToFile(...)?
There was a problem hiding this comment.
I also was not sure if the usage of AssemblyResources.ToFile(...) be used here inside GitInstaller or the result sent into the constructor.
There was a problem hiding this comment.
I also was not sure if the usage of AssemblyResources.ToFile(...) be used here inside GitInstaller or the result sent into the constructor.
Now that I say that out loud I feel the like call should be outside GitInstaller...
There was a problem hiding this comment.
Yeah, I agree it probably should be outside, this should only be concerned with extracting a zip given a file path.
StanleyGoldman
force-pushed
the
fixes/prefer-local-resources
branch
from
d7066db to
ec4038c
Compare
| } | ||
|
|
||
| var gitLfsArchivePath = AssemblyResources.ToFile(ResourceType.Platform, "git-lfs.zip", archiveParentPath, Environment); | ||
| if (!gitLfsArchivePath.FileExists()) |
There was a problem hiding this comment.
This feels a bit better.. Maybe a static method in GitInstaller would be better than this...
|
This has been manually ported to #609 |
GitInstallerto check locally for git and git lfs zip filesGitInstallerwill download the respective files