Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Task/Cache Jenga 2: Fixing initialization and git installation and other fixes #604

Closed
wants to merge 22 commits into from

Conversation

shana
Copy link
Member

@shana shana commented Mar 6, 2018

Built on top of shana/fix-tasks #609
Followed by #608

  • Merging in the loading spinner from Loading animation when the window is busy #583
  • deduping and killing unused code
  • fixing the git installation sequence
  • replaying cache invalidation requests that happen before RepositoryManager is set (because data might be requested and invalidated before we've had a chance to finish the initialization)
  • fixing the process task begin/end sequence (it could have thrown before OnEnd is called)

@shana shana changed the base branch from enhancements/gitcheckout to shana/kill-dead-code March 6, 2018 21:14
@shana shana force-pushed the shana/fix-initialization branch from 55e4fdc to b814a24 Compare March 6, 2018 21:23
@shana shana changed the title Fixing initialization and git installation and other fixes on top of enhancements/gitcheckout Fixing initialization and git installation and other fixes Mar 7, 2018
@shana shana changed the base branch from shana/kill-dead-code to shana/fix-tasks March 7, 2018 11:28
@shana shana changed the title Fixing initialization and git installation and other fixes Task/Cache Jenga 2: Fixing initialization and git installation and other fixes Mar 7, 2018
@shana
Copy link
Member Author

shana commented Mar 7, 2018

Closing this because the fixes to get this green need to go on top of shana/fix-refresh #608

@shana shana closed this Mar 7, 2018
@shana shana deleted the shana/fix-initialization branch April 5, 2018 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant