This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Allow login with email #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
suggested changes
Apr 19, 2018
| throw new InvalidOperationException("Authentication validation failed"); | ||
| } | ||
|
|
||
| keychain.SetToken(host, loginResultData.Token, validateResult.Output[1]); |
There was a problem hiding this comment.
This is not the only place where the username needs to be set, non-2fa login also needs it. And since we're always setting the user in the credential, why not make the username in SetToken mandatory? We always have it available in some form, and making it mandatory will allow us to make sure it's always sent in.
| keychain.SetToken(host, loginResultData.Token); | ||
| var octorunTask = new OctorunTask(taskManager.Token, nodeJsExecutablePath.Value, octorunScript.Value, "validate", | ||
| user: username, userToken: loginResultData.Token) | ||
| .Configure(processManager); |
There was a problem hiding this comment.
Do we need to run this every time, or only if the username is in email form?
shana
approved these changes
Apr 20, 2018
This was referenced Apr 20, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #685