Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Renaming metrics to indicate the user interaction that caused them #719

Merged
merged 20 commits into from
May 9, 2018
Merged

Renaming metrics to indicate the user interaction that caused them #719

merged 20 commits into from
May 9, 2018

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented May 7, 2018 •
edited by shana
Loading

These are the UI metrics being tracked in this PR:

  • numberOfStartups
  • projectsInitialized (repository initialized)
  • changesViewButtonCommit (commit from changes view)
  • historyViewToolbarFetch (fetch from toolbar in history view)
  • historyViewToolbarPush (push from toolbar in history view)
  • historyViewToolbarButtonPull (pull from toolbar in history view)
  • authenticationViewButtonAuthentication (authentication from auth window)
  • branchesViewButtonCreateBranch (create branch from branches view)
  • branchesViewButtonDeleteBranch (delete branch from branches view)
  • branchesViewButtonCheckoutLocalBranch (checkout local branch from branches view)
  • branchesViewButtonCheckoutRemoteBranch (checkout remote branch from branches view)
  • settingsViewUnlockButtonLfsUnlock (lfs unlock from settings view)
  • unityProjectViewContextLfsLock (lfs lock from Unity project window)
  • unityProjectViewContextLfsUnlock (lfs unlock from Unity project window)

@StanleyGoldman StanleyGoldman requested a review from shana May 7, 2018 15:57
@shana shana changed the title Renaming metrics to indication the user interaction that caused them Renaming metrics to indicate the user interaction that caused them May 7, 2018
shana
shana reviewed May 7, 2018
View reviewed changes
src/GitHub.Api/Application/ApplicationManagerBase.cs Outdated
@@ -168,7 +168,7 @@ public ITask InitializeRepository()
})
.ThenInUI(() =>
{
TaskManager.Run(UsageTracker.IncrementNumberOfProjectsInitialized);
TaskManager.Run(UsageTracker.Initialized);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialized is a bit too terse I think. ProjectsInitialized perhaps?

@shana
Copy link
Member

shana commented May 7, 2018

@StanleyGoldman I think this is missing the "repositories published" metrics.

@shana
Copy link
Member

shana commented May 7, 2018

Also the lfs locking/unlocking actions

@StanleyGoldman StanleyGoldman force-pushed the fixes/metrics-rename branch from 563ee9f to 3e2db8e Compare May 7, 2018 21:14
@StanleyGoldman StanleyGoldman merged commit 6108a44 into master May 9, 2018
@StanleyGoldman StanleyGoldman deleted the fixes/metrics-rename branch May 9, 2018 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@shana shana shana approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanleyGoldman @shana