Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented May 8, 2018

This pull request targets #720

I noticed a scenario where git chosen through settings will be overwritten with portable git on the system. This is mostly a copy of the code used to gind git on the system for a mac. So I wonder if the code should be refactored for a bit less repetition.

@shana shana force-pushed the fixes/update-check-git-setting branch from 79b47d1 to 6dfed1b Compare May 9, 2018 17:09
Copy link
Contributor Author

@StanleyGoldman StanleyGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@StanleyGoldman StanleyGoldman merged commit cf53058 into features/update-check May 9, 2018
@StanleyGoldman StanleyGoldman deleted the fixes/update-check-git-setting branch May 9, 2018 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants