This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Refactor how we run tasks synchronously so that TPL tasks aren't broken #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
force-pushed
the
fixes/fix-taskqueue-some-more
branch
4 times, most recently
from
3b8500e to
cb8edf5
Compare
Our task system uses TPL tasks (System.Threading.Tasks.Task) under the hood
(every ITask really is a TPL task whose body is the callback or
Run/RunWithReturn/RunWithData method override), so when we run one of our
ITask, what we're really doing is scheduling the underlying TPL task to be
executed. If we want to run the ITask synchronously, it's straightforward to
just execute the Run/RunWithReturn/RunWithData method that does the actual work.
Because of this, we also have an overload to pass in an existing TPL task into
an ITask, so that we can also run async/await task types in our threading system
(so that we can control the thread these tasks are going to be run in, given that
async/await has no threading control model).
The problem with allowing a TPL task to be set directly into an ITask is that the
TPL task wasn't set up in a way that exposed a Run/RunWithReturn/RunWithData
method that could be called synchronously.This PR moves things around so that
instead of calling directly the Run/RunWithReturn/RunWithData methods, there is one
RunSynchronously method that does the right thing for all task types, regardless of
how they're initialized.
This has the added benefit that the exact same method (`RunSynchronously`) is executed
independent of who's calling it
- if the ITask is running on the scheduler, `RunSynchronously` is the task body that
the scheduler will execute
- if the user wants to run it in thread, they can call it directly.
shana
force-pushed
the
fixes/fix-taskqueue-some-more
branch
from
cb8edf5 to
c439795
Compare
StanleyGoldman
approved these changes
Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our task system uses TPL tasks (System.Threading.Tasks.Task) under the hood (every ITask really is a TPL task whose body is the callback or Run/RunWithReturn/RunWithData method override), so when we run one of our ITask, what we're really doing is scheduling the underlying TPL task to be executed. If we want to run the ITask synchronously, it's straightforward to just execute the Run/RunWithReturn/RunWithData method that does the actual work.
Because of this, we also have an overload to pass in an existing TPL task into an ITask, so that we can also run async/await task types in our threading system (so that we can control the thread these tasks are going to be run in, given that async/await has no threading control model).
The problem with allowing a TPL task to be set directly into an ITask is that the TPL task wasn't set up in a way that exposed a Run/RunWithReturn/RunWithData method that could be called synchronously.This PR moves things around so that instead of calling directly the Run/RunWithReturn/RunWithData methods, there is one RunSynchronously method that does the right thing for all task types, regardless of how they're initialized. This has the added benefit that the exact same method (
RunSynchronously) is executed independent of who's calling it - if the ITask is running on the scheduler,RunSynchronouslyis the task body that the scheduler will execute, and if the user wants to run it in thread, they can call it directly.