This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fixing date parsing for VSTS repos #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
reviewed
Jun 20, 2018
src/GitHub.Api/Helpers/SimpleJson.cs
Outdated
| @@ -1369,9 +1369,9 @@ public virtual object DeserializeObject(object value, Type type) | |||
| if (type == typeof(NPath) || (ReflectionUtils.IsNullableType(type) && Nullable.GetUnderlyingType(type) == typeof(NPath))) | |||
| return new NPath(str); | |||
| if (type == typeof(DateTime) || (ReflectionUtils.IsNullableType(type) && Nullable.GetUnderlyingType(type) == typeof(DateTime))) | |||
| return DateTime.ParseExact(str, Iso8601Format, CultureInfo.InvariantCulture, DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal); | |||
| return DateTime.ParseExact(str, Constants.Iso8601Formats, CultureInfo.InvariantCulture, DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal); | |||
There was a problem hiding this comment.
I'd rather have Iso8601Format point to Constants instead of hardcoding that here, it's easier to maintain that way I think
shana
reviewed
Jun 20, 2018
src/GitHub.Api/Helpers/Constants.cs
Outdated
| public static readonly string[] Iso8601Formats = { | ||
| Iso8601FormatZ, | ||
| @"yyyy-MM-dd\THH\:mm\:ss.fffffffzzz", | ||
| Iso8601Format, | ||
| Iso8601FormatPointZ, |
There was a problem hiding this comment.
The Iso8601Format and Iso8601FormatZ are the preferred ones, which is why I made them into consts, but we'll need way more. This list probably needs to read more like
public static readonly string[] Iso8601Formats = {
Iso8601Format,
Iso8601FormatZ,
@"yyyy-MM-dd\THH\:mm\:ss.fffffffzzz",
@"yyyy-MM-dd\THH\:mm\:ss.ffffffzzz",
@"yyyy-MM-dd\THH\:mm\:ss.fffffzzz",
@"yyyy-MM-dd\THH\:mm\:ss.ffffzzz",
@"yyyy-MM-dd\THH\:mm\:ss.ffzzz",
@"yyyy-MM-dd\THH\:mm\:ss.fzzz",
@"yyyy-MM-dd\THH\:mm\:sszzz",
@"yyyy-MM-dd\THH\:mm\:ss.fffffff\Z",
@"yyyy-MM-dd\THH\:mm\:ss.ffffff\Z",
@"yyyy-MM-dd\THH\:mm\:ss.fffff\Z",
@"yyyy-MM-dd\THH\:mm\:ss.ffff\Z",
@"yyyy-MM-dd\THH\:mm\:ss.fff\Z",
@"yyyy-MM-dd\THH\:mm\:ss.ff\Z",
@"yyyy-MM-dd\THH\:mm\:ss.f\Z",
};
shana
approved these changes
Jun 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835
Update by @shana:
This adds more milisecond precision variants to the ISO8601 formats, given that different servers return different variations of the standard. Because standards.