Feature: Link from code to GitHub via context menus #191

shana · 2016-01-12T18:07:16Z

Fixes #106

This needs:

PR New menu handling system #187 - New menu handling system in master
PR Add a status bar notification service #220 - Status bar notification service
PR Update octicons #221 - Octicons update
Notification when link is copied on the status bar
Code review

Quick stub of the VS file apis required for a potential "Get Link" feature - gets the current file name and line number to build a github url of it for sharing.

Tests are failing on the buildbot and it looks like it's because one test is clobbering data for another test. The only thing these tests share is the global ServiceProvider set, so put these test classes in the same collection so xunit doesn't parallelize them.

shana · 2016-02-08T21:51:55Z

This is how it looks like currently.

@donokuda @haacked Should we keep these context menu entries like this (considering we have potentially more context menus to add), or should we have a GitHub context menu entry with these as submenus?

shana · 2016-02-08T22:11:55Z

@haacked This is ready for 👀. A few things in here are part of PR #220 so might want to deal with that one first.

haacked · 2016-02-08T22:23:20Z

People gonna be upset if we add too much to the context menu. If there isn't already a grouping that makes sense, we should group our commands in a top level "GitHub" menu.

donokuda · 2016-02-08T22:27:40Z

People gonna be upset if we add too much to the context menu. If there isn't already a grouping that makes sense, we should group our commands in a top level "GitHub" menu.

👍 I can see us having to do this anyway as we integrate more features (such as creating a gist.)

haacked · 2016-02-08T23:27:45Z

src/GitHub.Exports/Extensions/SimpleRepositoryModelExtensions.cs

+        public static string CurrentSha(this ISimpleRepositoryModel repository)
+        {
+            var repo = GitService.GitServiceHelper.GetRepo(repository.LocalPath);
+            return repo.Commits.FirstOrDefault()?.Sha;


Could repo be null here? Should this be repo?.Commits.FirstOrDefault()?.Sha?

shana · 2016-02-09T13:08:28Z

I've moved things to a submenu and cleaned up. The icons look like crap though, even though they're xaml icons. Feels like the xaml versions of the octicons that we have have strokes that are too wide?

haacked · 2016-02-09T16:58:56Z

I think we need an icon for the top level GitHub menu item. What do you think @donokuda and @shana?

shana · 2016-02-09T17:01:32Z

@haacked Would love to, but unfortunately it seems VS does not support icons on menu entries that lead to submenus 😢

haacked · 2016-02-09T21:21:34Z

@haacked Would love to, but unfortunately it seems VS does not support icons on menu entries that lead to submenus

😢 /cc @acangialosi feature request!

haacked · 2016-02-09T21:24:48Z

@shana I just have the one question about the private class that's exported.

shana · 2016-02-10T20:27:05Z

@haacked I've gone and 🔨 all the things you mentioned. I still need to fix the icons so they look half decent, so don't merge this quite yet.

haacked · 2016-02-10T20:29:38Z

Slowly takes finger off the big green button

shana · 2016-02-10T20:40:37Z

niik · 2016-02-10T21:11:05Z

@shana A+

Any xaml file that includes a SharedDictionaryManager resource dictionary with the uri "Theme.xaml" will get a themed dictionary included instead that tracks the VS theme and gets switched at runtime whenever the VS theme changes.

shana · 2016-02-19T22:29:01Z

@haacked

Fixed the icon sizes. Also fixed the colors to match the colors of other context menus in VS. In the process, added a little extra code to support theming, so now we have three separate theme xaml files that define colors for the three themes VS comes with - Dark, Light and Blue.

Any xaml file that includes a SharedDictionaryManager resource dictionary with the uri "Theme.xaml" will get a themed dictionary included instead that tracks the VS theme and gets switched at runtime whenever the VS theme changes. If VS is running an unknown theme, the code detects whether it's a dark or light theme (based on brightness) and loads our dark or light theme file to match.

Test run

green for dark theme, blue for blue theme, red for light theme

Dark

Light

Blue

donokuda · 2016-02-19T22:40:33Z

Any xaml file that includes a SharedDictionaryManager resource dictionary with the uri "Theme.xaml" will get a themed dictionary included instead that tracks the VS theme and gets switched at runtime whenever the VS theme changes. If VS is running an unknown theme, the code detects whether it's a dark or light theme (based on brightness) and loads our dark or light theme file to match.

green for dark theme, blue for blue theme, red for light theme

Are these colors just for demonstrating how theming works?

shana · 2016-02-19T22:43:21Z

Are these colors just for demonstrating how theming works?

@donokuda Yeah, I couldn't actually tell the difference. I'm actually using the same color for those icons on all three themes, and VS is apparently inverting the color on the dark theme when rendering the icons (got me so confused initially when I set it to white and it showed up black and vice-versa...), so I set them to RGB to make sure it was working (and recorded proof for future self)

donokuda · 2016-02-19T23:00:27Z

👍 That's what I thought. Love this!

haacked · 2016-02-22T19:34:16Z

This feature feels like magic!

Feature: Link from code to GitHub via context menus

Atcold · 2020-07-16T20:25:54Z

How does one activate this?

shana and others added 11 commits January 7, 2016 15:35

Stub of "Get Link" feature

e4c8162

Quick stub of the VS file apis required for a potential "Get Link" feature - gets the current file name and line number to build a github url of it for sharing.

Basic implementation for opening selection in browser

069dc80

Refactored browser url creation and added copy to clipboard menu item

d4d7762

Merge master into feature/link-to-vs

ed5711b

Merge pull request #184 from austin94/feature/link-to-vs

3df7b6c

Merge branch 'shana/new-menu-system' into feature/link-to-vs

60b2a70

Give IActiveDocument a better name

068c43a

Give a better name to the open link command

72828e2

Move open/copy link to MEF menus and cleanup

b36c02c

Add tests for url generation

d8b2d16

Attempt at fixing tests

172aba3

Tests are failing on the buildbot and it looks like it's because one test is clobbering data for another test. The only thing these tests share is the global ServiceProvider set, so put these test classes in the same collection so xunit doesn't parallelize them.

shana self-assigned this Jan 13, 2016

shana added the feature label Jan 13, 2016

shana changed the title ~~Feature: Link from code to GitHub via context menus~~ [WIP] Feature: Link from code to GitHub via context menus Jan 13, 2016

georgebearden mentioned this pull request Jan 19, 2016

Copy the file name when creating a gist #197

Closed

Merge master into feature/link-to-vs

2c61005

shana added 2 commits February 8, 2016 23:03

Merge feature/status-bar-notifications into feature/link-to-vs

a4f8516

Show statusbar message when a link is copied

f297056

shana changed the title ~~[WIP] Feature: Link from code to GitHub via context menus~~ Feature: Link from code to GitHub via context menus Feb 8, 2016

shana assigned haacked and unassigned shana Feb 8, 2016

shana mentioned this pull request Feb 8, 2016

Add a status bar notification service #220

Merged

haacked reviewed Feb 8, 2016
View reviewed changes

Move commands to submenu

2b49df3

Make the export public

2a8582a

Merge master into feature/link-to-vs

a8d2427

shana added 4 commits February 19, 2016 23:12

Don't need this anymore

006eb83

Add theming

a9c0614

Any xaml file that includes a SharedDictionaryManager resource dictionary with the uri "Theme.xaml" will get a themed dictionary included instead that tracks the VS theme and gets switched at runtime whenever the VS theme changes.

Fix context menu icon colors and sizes

b5c7b35

Don't need a viewbox here

e5f269f

shana assigned haacked and unassigned shana Feb 20, 2016

Fix rendering of icons

808e859

shana mentioned this pull request Feb 22, 2016

Design time theme colors #224

Closed

1 task

haacked added a commit that referenced this pull request Feb 22, 2016

Merge pull request #191 from github/feature/link-to-vs

cadea92

Feature: Link from code to GitHub via context menus

haacked merged commit cadea92 into master Feb 22, 2016

haacked deleted the feature/link-to-vs branch February 22, 2016 19:34

shana mentioned this pull request Feb 23, 2016

Design time theme colors #225

Merged

1 task

Feature: Link from code to GitHub via context menus #191

Feature: Link from code to GitHub via context menus #191

Uh oh!

Conversation

shana commented Jan 12, 2016

Uh oh!

shana commented Feb 8, 2016

Uh oh!

shana commented Feb 8, 2016

Uh oh!

haacked commented Feb 8, 2016

Uh oh!

donokuda commented Feb 8, 2016

Uh oh!

haacked Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

shana commented Feb 9, 2016

Uh oh!

haacked commented Feb 9, 2016

Uh oh!

shana commented Feb 9, 2016

Uh oh!

haacked commented Feb 9, 2016

Uh oh!

haacked commented Feb 9, 2016

Uh oh!

shana commented Feb 10, 2016

Uh oh!

haacked commented Feb 10, 2016

Uh oh!

shana commented Feb 10, 2016

Uh oh!

niik commented Feb 10, 2016

Uh oh!

shana commented Feb 19, 2016

Test run

Dark

Light

Blue

Uh oh!

donokuda commented Feb 19, 2016

Uh oh!

shana commented Feb 19, 2016

Uh oh!

donokuda commented Feb 19, 2016

Uh oh!

haacked commented Feb 22, 2016

Uh oh!

Atcold commented Jul 16, 2020

Uh oh!

Uh oh!