New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition causing crash in Publish form #192

Merged
merged 2 commits into from Jan 12, 2016

Conversation

Projects
None yet
2 participants
@shana
Collaborator

shana commented Jan 12, 2016

See #188

Nate Price and others added some commits Jan 12, 2016

Nate Price
Stopped crash after publishing new repository
Visual Studio crashed after publishing, but the publishing process
completed before the crash. A call was made to a disposed object after
the view changed, causing the disposal.
Fix race condition
The `ListenToCompletionState` subscription was triggering a navigation
request on the `Next` callback. Depending on how fast VS responds, this
can cause the Sync section to be disposed, along with the `UIController`
instance, before the handler returns, which would cause `UIController`
to crash.

Make sure we only navigate away once the `ListenToCompletionState`
observable is completed, and also tweak the way `Dispose` happens in
`UIController` to minimize races.

Haacked added a commit that referenced this pull request Jan 12, 2016

Merge pull request #192 from github/fixes/crash-after-publish
Fix race condition causing crash in Publish form

@Haacked Haacked merged commit e4cf04c into master Jan 12, 2016

3 checks passed

GitHub CLA @shana has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #2648983 succeeded in 87s
Details
jenkins/build_log Jenkins Build Log
Details

@Haacked Haacked deleted the fixes/crash-after-publish branch Jan 12, 2016

@Haacked

This comment has been minimized.

Show comment
Hide comment
@Haacked

Haacked Jan 12, 2016

Member

Nice catch!

Member

Haacked commented Jan 12, 2016

Nice catch!

@amytruong amytruong referenced this pull request Jan 20, 2016

Closed

QA for Version 1.0.16.3 #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment