This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix race condition causing crash in Publish form #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio crashed after publishing, but the publishing process completed before the crash. A call was made to a disposed object after the view changed, causing the disposal.
The `ListenToCompletionState` subscription was triggering a navigation request on the `Next` callback. Depending on how fast VS responds, this can cause the Sync section to be disposed, along with the `UIController` instance, before the handler returns, which would cause `UIController` to crash. Make sure we only navigate away once the `ListenToCompletionState` observable is completed, and also tweak the way `Dispose` happens in `UIController` to minimize races.
haacked
added a commit
that referenced
this pull request
Jan 12, 2016
Fix race condition causing crash in Publish form
|
✨ Nice catch! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #188