Don't change working directory when loading in ghe-backup-config #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,22 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
| #!/bin/sh | |||
| version_info="$BACKUP_UTILS_VERSION" | ||
| ref=$(git rev-parse HEAD || true) | ||
| ref=$(git --git-dir=$GHE_BACKUP_ROOT/.git rev-parse HEAD || true) |
There was a problem hiding this comment.
I used --git-dir here instead of -C to ensure the greatest backwards compatibility with Git.
|
@snh neat, looks good to me ✨ |
|
|
zachary-mark
pushed a commit
that referenced
this pull request
May 3, 2021
Add support for both ghe-redis-cli and redis-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we change the working directory to the root backup-utils directory in each script. A number of scripts, such as
ghe-backup-config, assume and therefore depend on this being the case.This PR removes this, and instead sets
GHE_BACKUP_ROOTto the root directory of backup-utils and uses this when referencing other scripts and files, instead of assuming the working directory is the root backup-utils directory.Depends on #189 for the tests to pass.
/cc @github/backup-utils