Skip to content

Conversation

bevns
Copy link
Contributor

@bevns bevns commented Nov 11, 2016

Adds a message if No leaked keys are found. The current behavior is to just echo "Checking for leaked ssh keys ..." and then exit if no leaked keys are found. (

echo "Checking for leaked ssh keys ..."
). This can sometimes be confusing if users are expecting output before the backup or restore process exits.

bevns and others added 2 commits November 10, 2016 16:10
Adds a message if No leaked keys are found.  The current behavior is to just echo **"Checking for leaked ssh keys ..."** and then exit if no leaked keys are found. (https://github.com/github/backup-utils/blob/c299602f863b808e45f1b90e8a4ad632ffb3c7ad/bin/ghe-backup#L261). This can sometime be confusing if users are expecting output before the backup or restore process completes.
Copy link
Member

@rubiojr rubiojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bevns, makes sense to me.

@rubiojr rubiojr merged commit a30ed3d into master Nov 14, 2016
@rubiojr rubiojr deleted the bevns/ghe-detect-leaked-ssh-keys branch November 14, 2016 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants