Use old rsync restore method for pages prior to 2.13 #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for restoring to pre-2.13 releases and was missed when I did something similar for repo, storage and gist restores.
rubiojr
approved these changes
Aug 20, 2018
Merged
dooleydevin
added a commit
that referenced
this pull request
Jul 21, 2023
…t-always-restore-column-encryption-keys Backport 349 for 3.7: Always restore column encryption keys
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unifying the backup and restore approach in #375 we opted to keep using the old behaviour when restoring to hosts running versions prior to GitHub Enterprise 2.13.0 to remove a requirement for a specific GitHub Enterprise release in order to restore.
024cb1f is where I implemented this for repositories and gists but I completely forgot about pages.
This PR adds back the
ghe-restore-pages-rsyncscript required for those older releases and uses it instead of the newer approach.This will fix problems restoring to GitHub Enterprise 2.12.5 and earlier.
Fixes https://github.com/github/backup-utils/issues/425
/cc @terrorobe @rubiojr